Skip to content

Conversation

jsimmons
Copy link
Contributor

@jsimmons jsimmons commented Jul 17, 2025

This PR stabilizes

impl<T, const N: usize> Cell<[T; N]> {
    pub const fn as_array_of_cells(&self) -> &[Cell<T>; N];
}

Stabilization report: #88248 (comment)
Closes: #88248

@rustbot
Copy link
Collaborator

rustbot commented Jul 17, 2025

r? @thomcc

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 17, 2025
@tgross35 tgross35 added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Jul 17, 2025
@tgross35
Copy link
Contributor

Cc @rust-lang/wg-const-eval because this includes a (trivial) const stabilization

@jieyouxu jieyouxu added WG-const-eval Working group: Const evaluation T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 17, 2025
@jieyouxu
Copy link
Member

r? libs-api

@rustbot rustbot assigned BurntSushi and unassigned thomcc Jul 17, 2025
@oli-obk
Copy link
Contributor

oli-obk commented Jul 17, 2025

Jup this is fine from the const side

@Amanieu
Copy link
Member

Amanieu commented Jul 22, 2025

The name is consistent with the existing stable as_slice_of_cells method.

@rfcbot merge

@rfcbot
Copy link

rfcbot commented Jul 22, 2025

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Jul 22, 2025
@Amanieu Amanieu removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Jul 22, 2025
@rfcbot rfcbot added the disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. label Jul 22, 2025
@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Aug 5, 2025
@rfcbot
Copy link

rfcbot commented Aug 5, 2025

🔔 This is now entering its final comment period, as per the review above. 🔔

@tgross35 tgross35 assigned tgross35 and unassigned BurntSushi Aug 5, 2025
@tgross35 tgross35 added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2025
@rfcbot rfcbot added the finished-final-comment-period The final comment period is finished for this PR / Issue. label Aug 15, 2025
@rfcbot rfcbot removed the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Aug 15, 2025
@rfcbot
Copy link

rfcbot commented Aug 15, 2025

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@tgross35
Copy link
Contributor

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 15, 2025

📌 Commit 14c6e50 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 15, 2025
bors added a commit that referenced this pull request Aug 15, 2025
Rollup of 11 pull requests

Successful merges:

 - #143717 (Add `Default` impls for `Pin`ned `Box`, `Rc`, `Arc`)
 - #144054 (Stabilize as_array_of_cells)
 - #144907 (fix: Reject async assoc fns of const traits/impls in ast_passes)
 - #144922 (Implement `#[derive(From)]`)
 - #144963 (Stabilize `core::iter::chain`)
 - #145436 (fix(tests/rmake/wasm-unexpected-features): change features from `WASM1` to `MVP`)
 - #145453 (Remove duplicated tracing span in bootstrap)
 - #145454 (Fix tracing debug representation of steps without arguments in bootstrap)
 - #145455 (Do not copy files in `copy_src_dirs` in dry run)
 - #145462 (Stabilize `const_exposed_provenance` feature)
 - #145466 (Enable new `[range-diff]` feature in triagebot)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7a05f26 into rust-lang:master Aug 16, 2025
11 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 16, 2025
rust-timer added a commit that referenced this pull request Aug 16, 2025
Rollup merge of #144054 - jsimmons:stabilize-as-array-of-cells, r=tgross35

Stabilize as_array_of_cells

This PR stabilizes

```rust
impl<T, const N: usize> Cell<[T; N]> {
    pub const fn as_array_of_cells(&self) -> &[Cell<T>; N];
}
```

Stabilization report: #88248 (comment)
Closes: #88248
@jhpratt
Copy link
Member

jhpratt commented Aug 16, 2025

still in queue; merged in #145475

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 16, 2025
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Aug 18, 2025
…ls, r=tgross35

Stabilize as_array_of_cells

This PR stabilizes

```rust
impl<T, const N: usize> Cell<[T; N]> {
    pub const fn as_array_of_cells(&self) -> &[Cell<T>; N];
}
```

Stabilization report: rust-lang#88248 (comment)
Closes: rust-lang#88248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. to-announce Announce this issue on triage meeting WG-const-eval Working group: Const evaluation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue for Cell::as_array_of_cells